secure-ls icon indicating copy to clipboard operation
secure-ls copied to clipboard

Published 20 hours ago • verified publisher icon softvar

10 add support for custom storage type - [NEEDS WORK]

Open paulcpk opened this issue 7 years ago • 8 comments

Closes #10

paulcpk avatar Jul 09 '18 12:07 paulcpk

Coverage Status

Coverage increased (+0.02%) to 85.898% when pulling 4eb4ab84aece970b6bb0814068ed6f68cecf1a13 on fonkgoku:10-add-support-for-custom-storage-type into 0c4bbfded098ae015fb0c34b09421717ad15401f on softvar:master.

coveralls avatar Jul 09 '18 12:07 coveralls

I actually wrote a test for the additional functionality, should I do something about the decreased test coverage?

paulcpk avatar Jul 09 '18 13:07 paulcpk

@softvar it would be great if you could take a look at this, thank you!

4F2E4A2E avatar Jul 10 '18 15:07 4F2E4A2E

@fonkgoku @4F2E4A2E Sure. kinda busy with office work, will check this weekend surely. Meanwhile, can you please take out some time to write some test cases for the new code and thereby maintaining the code coverage too. Thanks!

softvar avatar Jul 11 '18 20:07 softvar

@softvar I added some more tests, looking forward to your review :)

paulcpk avatar Jul 12 '18 14:07 paulcpk

I have reviewed the PR and left some comments. Addressing those comments would ensure the library would be working fine with both the types.

Also, since we have examples too, merging this PR without having sessionStorage examples would be incomplete. Please take out some time to add some sessionStorage examples in different files.

Feel free to ask if you have any doubt.

Thanks!

softvar avatar Jul 14 '18 12:07 softvar

Any updates @fonkgoku ? Please let me know if you need any help from my side.

softvar avatar Jul 25 '18 19:07 softvar

Sorry for the late reply, I was still waiting for a reply on this comment https://github.com/softvar/secure-ls/pull/11#discussion_r202618792

paulcpk avatar Jul 31 '18 09:07 paulcpk