soda-core icon indicating copy to clipboard operation
soda-core copied to clipboard

Don't use strtobool from distutils

Open akx opened this issue 1 year ago • 3 comments

Inspired by this question – one shouldn't need distutils/setuptools just to see if a string feels truthy.

The set of truthy-feeling strings was borrowed from setuptools.

Fixes #2091.

akx avatar Aug 06 '24 11:08 akx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 06 '24 11:08 CLAassistant

strtobool is also used in env_helper.py and should also be replaced, https://github.com/sodadata/soda-core/blob/main/soda/core/soda/common/env_helper.py#L4

It would be great if this PR can also address env_helper

Swastik-SQED avatar Jul 22 '25 09:07 Swastik-SQED

@Swastik-SQED Sure – this PR is open for maintainers to edit as they see fit. That file was added 2 months ago, this PR was created nearly a year ago... I didn't have a crystal ball at that point :)

akx avatar Jul 22 '25 15:07 akx