soda-core
soda-core copied to clipboard
Don't use strtobool from distutils
Inspired by this question – one shouldn't need distutils/setuptools just to see if a string feels truthy.
The set of truthy-feeling strings was borrowed from setuptools.
Fixes #2091.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
strtobool is also used in env_helper.py and should also be replaced,
https://github.com/sodadata/soda-core/blob/main/soda/core/soda/common/env_helper.py#L4
It would be great if this PR can also address env_helper
@Swastik-SQED Sure – this PR is open for maintainers to edit as they see fit. That file was added 2 months ago, this PR was created nearly a year ago... I didn't have a crystal ball at that point :)