sockjs-protocol icon indicating copy to clipboard operation
sockjs-protocol copied to clipboard

wrong asserts for callback

Open fleonis opened this issue 10 years ago • 2 comments

hello

it seems wrong to test like this

self.assertTrue('"callback" parameter required' in r.body)

the body should content something like this

c["\"callback\" parameter required"]

or like this

p("c[\"\"callback\" parameter required\"]");

so?

and test fails

fleonis avatar Nov 12 '15 11:11 fleonis

Which test? Can you link to a line?

brycekahle avatar Nov 17 '15 18:11 brycekahle

https://github.com/sockjs/sockjs-protocol/blob/532a8c0628c4980bc78930f3929a8d99dcc5b32c/sockjs-protocol.py#L1111 https://github.com/sockjs/sockjs-protocol/blob/532a8c0628c4980bc78930f3929a8d99dcc5b32c/sockjs-protocol.py#L1102 https://github.com/sockjs/sockjs-protocol/blob/532a8c0628c4980bc78930f3929a8d99dcc5b32c/sockjs-protocol.py#L1046 https://github.com/sockjs/sockjs-protocol/blob/532a8c0628c4980bc78930f3929a8d99dcc5b32c/sockjs-protocol.py#L1037

but may be more.. i cannot test it for now

and i mean the body

c["\"callback\" parameter required"]

fleonis avatar Nov 18 '15 19:11 fleonis