socket.io icon indicating copy to clipboard operation
socket.io copied to clipboard

Errors when using uWebsockets while clients are connected and server restarts

Open GetThatCookie opened this issue 7 months ago • 1 comments

Describe the bug Hi,

at my company we are in the middle of switching from express to uWebSockets.

We use

  • Nestjs
  • Ultimate-Express
  • socket.io with attachApp
  • engine.use(sessionMiddleware) <- thats the problem... or maybe not? (express-session)

While everything works really good, there is one thing we get errors.

  1. Server starts deployment, after that clients can connect and everything works
  2. Server goes down, restarts, etc. the client browser stays open!!
  3. When Server is up again, the reconnecting begins (sessionMiddleware is called)
  4. Various errors are showing up:

Image

  1. Ok so I first thought hmm my sessionMiddleware does some bad things
  2. But after some debugging, I could fix it quite easy in uServer -> handleUpgrade

Image

  1. I had to cork the response write and upgrade
  2. I saved the header before entering the async callback

I'm sry that I cannot really give a code example for this problem.

But does this seems to be a bug or just a problem in my project?

Nice to know, I absolutely don't have any error or problems after changing these few lines.

(Re-)Connecting with engine.use and express-session middleware works like a charm.

Platform:

  • OS: [e.g. Linux, Windows, Mac]

Thanks in advance!

GetThatCookie avatar Apr 17 '25 19:04 GetThatCookie