socket.io-client-swift icon indicating copy to clipboard operation
socket.io-client-swift copied to clipboard

v16.1.1

Open nuclearace opened this issue 1 year ago • 20 comments

Fixes for various connection status stuff

nuclearace avatar Nov 13 '23 20:11 nuclearace

@WestFlow127 LMK how testing goes

nuclearace avatar Nov 13 '23 20:11 nuclearace

@WestFlow127 LMK how testing goes

@nuclearace , I pulled the repo, switch to this PR, and ran all tests in TestSocketIO and all passed! Is there anything else you'd like me to do?

WestFlow127 avatar Nov 14 '23 01:11 WestFlow127

@WestFlow127, if you're able, testing against a socket.io server and doing some basic sanity checks would be helpful

nuclearace avatar Nov 14 '23 15:11 nuclearace

@nuclearace I can do that, we run a socket.io server at my company. I'll test general functionality, various reconnection scenarios, and the timingOut fix.

WestFlow127 avatar Nov 14 '23 16:11 WestFlow127

Update:

Was able to test general functionality which was good. Testing various reconnects was difficult due to my locations poor 5G service. I want to test on stable/good connections. Will likely do so over the holiday. (@nuclearace )

WestFlow127 avatar Dec 21 '23 19:12 WestFlow127

I can see that this version fixes the issue i just reported on #1470 Need any help with getting anything done to prepare this for release? @nuclearace @WestFlow127

mahyarq avatar Dec 23 '23 23:12 mahyarq

Any ETA for this release?

miguelaboliveira avatar Jan 12 '24 15:01 miguelaboliveira

I have the green light to resume testing this PR during my workday tomorrow. Going to further test socket reconnects using cellular service with our live socket server. Stay tuned @nuclearace

WestFlow127 avatar Jan 19 '24 01:01 WestFlow127

Just finished testing 5G/cellular reconnects and it worked great. Immediately reconnected to socket upon 5G reconnection. I believe this PR is good to go, @nuclearace

WestFlow127 avatar Jan 19 '24 21:01 WestFlow127

More users of this repo are requesting this to be merged: https://github.com/socketio/socket.io-client-swift/pull/1375#issuecomment-1919443113

@nuclearace I support merging this as I have tested it against our socket server.

WestFlow127 avatar Jan 31 '24 23:01 WestFlow127

More users of this repo are requesting this to be merged: #1375 (comment)

@nuclearace I support merging this as I have tested it against our socket server.

Can we get it in? Would solve a big issue we're facing! 🙏🏼 // @nuclearace

xmollv avatar Feb 01 '24 21:02 xmollv

@nuclearace Please read above comments 🙏🏼

WestFlow127 avatar Feb 13 '24 18:02 WestFlow127

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

Crysis21 avatar Mar 19 '24 08:03 Crysis21

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

We have the same question. Both on the server and on Android everything seems to work fine, but on iOS we're constantly battling issues due to the unreliability of this SDK. This PR made it somewhat better, but still seems that there's a ton of room for improvement - yet there doesn't seem to be any active development.

xmollv avatar Mar 19 '24 08:03 xmollv

for us and many other people, the swift client doesn't connect in WS mode, only in polling. using latest nodeJS backend and android works flawless. sadly this is not the case with swift.

Crysis21 avatar Mar 19 '24 08:03 Crysis21

@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly.

Sorry about this, life has sadly been quite rough this past year and I haven't been able to devote much spare time outside of work and family. I'm hoping to start circle back in the coming months

nuclearace avatar Mar 19 '24 13:03 nuclearace

for us and many other people, the swift client doesn't connect in WS mode, only in polling. using latest nodeJS backend and android works flawless. sadly this is not the case with swift.

Looking into this now

nuclearace avatar Mar 19 '24 13:03 nuclearace

@nuclearace Things to add to this version:

  • Updated Privacy Manifest
  • Update Starscream to v4.0.8

WestFlow127 avatar May 08 '24 02:05 WestFlow127