engine.io-client icon indicating copy to clipboard operation
engine.io-client copied to clipboard

Change URL max length to 8000 or at least add option/config

Open tolu opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe.

The newly introduced limit on 2000 characters for URL's is breaking our implementation since we pass JWT's that are generally large as query parameters... If that is a good or bad idea, let's leave that aside. It's at least a solution we've had in production for at least 6 years.

Describe the solution you'd like

Could the limit be raised to 8000?

From https://www.rfc-editor.org/rfc/rfc9110#section-4.1-5

It is RECOMMENDED that all senders and recipients support, at a minimum, URIs with lengths of 8000 octets in protocol elements. Note that this implies some structures and on-wire representations (for example, the request line in HTTP/1.1) will necessarily be larger in some cases.

Or at least be controlled via an optional parameter/config or some such in order to at least not break in the presence of fully valid URL's. 🙏

tolu avatar Nov 29 '23 10:11 tolu