python-youtube icon indicating copy to clipboard operation
python-youtube copied to clipboard

Update to requests-oauthlib 2.0.0

Open z1lc opened this issue 1 year ago • 3 comments

https://pypi.org/project/requests-oauthlib/ recently updated to 2.0.0. The poetry specification requires <2.0.0:

https://github.com/sns-sdks/python-youtube/blob/45b0b2284d9b4ab8c41529366dcfec03492f39ba/pyproject.toml#L35

z1lc avatar Mar 23 '24 14:03 z1lc

@MerleLiuKun / @pidi3000 any thoughts here? I can't upgrade the version of this library in my own project since pip complains that python-youtube limits the max version.

This also is now also affecting isodate, since 0.7.2 was recently released: https://github.com/sns-sdks/python-youtube/blob/45b0b2284d9b4ab8c41529366dcfec03492f39ba/pyproject.toml#L36

z1lc avatar Oct 12 '24 20:10 z1lc

I will take care of this issue this week. :)

MerleLiuKun avatar Oct 15 '24 09:10 MerleLiuKun

I see no issue updating requests-oauthlib. I'd suggest setting it to something like requests-oauthlib = ">=1.3.0,<3.0.0".

This way all of v2 is included. Since they seem to have started following semantic versioning this should not cause problems and version 3 might add breaking changes.

Updating isodate to the newest version of 0.7.2 will also require increasing python-youtube's minimum python version from 3.6 to 3.7. Probably best to pin to 0.7.2 or limiting it to be no higher to avoid problems. Since 0.7.3 seems to plan dropping support for python versions below 3.9. (isodate changes)

I propose setting it to isodate = ">=0.6.0,<=0.7.2" for now.

Of course doing some tests after changing the versions

pidi3000 avatar Oct 15 '24 19:10 pidi3000

@MerleLiuKun with #184 merged I think this can be closed

pidi3000 avatar Oct 27 '24 20:10 pidi3000