Sunrise

Results 14 comments of Sunrise

> There are some merge conflicts that I'll fix if you are open to this PR. I'd like to fix the implementation of Owned. Hi @nerdrew! I'm currently working on...

Hi! Thanks for letting me know! I've just newly cloned the master branch and ran the `run_test.sh` script; seemed to work though, even after multiple times. ### My procedure ```bash...

## Performance hit Hi! Could I ask if you've run any tests to see what the performance hit is like? I've run some quick tests (code further below) and it...

Oh, by the way I think #247 should solve this (as part of our implementation of field presence, we had to fix the `impl Default` system).

Hi! Since this seems to be a common stumbling block for new users, would you guys prefer: 1. Modify `serialize_into_slice()` and `deserialize_from_slice()` to no longer include the length prefix 2....

Hi! The PR looks good; I was actually considering a few options, since this seems to be a common stumbling block for new users: - Modify `serialize_into_slice()` and `deserialize_from_slice()` to...

In my opinion, since we already have breaking changes from other PRs that look like they're going to be merged, let's go with option 1 above. That is, just change...

Thanks for the feedback! One concern I have can be shown in the following example: ```protobuf syntax = "proto2"; message A { optional int32 a = 1 [default=3]; } ```...

That sounds like a good idea! I'm currently experimenting with implementing this or something similar for all singular fields (as `SettableField`), since it isn't only `optional` fields that have this...

Just an update, over the course of thinking/testing I've found some problems that arise with these suggestions: ### Set/Unset - Since we rely on the `Unset()` variant containing the correct...