snozbot
Update Fungus to conform to updated Asset Store Package rules.
When attempting to publish 3.13.7 to the asset store we ran into a number of rule violations due to changes in asset store package requirements. Until these are resolved we will not be shown on the asset store.
ttps://unity3d.com/asset-store/sell-assets/submission-guidelines
- [ ] Ensure all assets have a attribution or copyright attached to them
- [ ] Ensure offline doco exists and is easy to find
- [ ] Ensure we do not reference thirdparty trademarks
- [ ] Update folder structure to match guidelines
- [ ] Ensure all audio assets are lossless
- [ ] Ensure package does not require, reference, or contain other packages
Any work on this? Would be wonderful to see Fungus back in Asset Store. I'm kinda new to unity packages, but for me, to solve the last part, looks live we will need to split packages. Like
Fungus Fungus LeanTween Integration and so on...
It would be awesome if we could just reference other packages like in composer or npm, but I don't think Unity currently supports it.
Plenty of other assets break integrations into separate assets and just link in the description. Removing the 2 unitypackage files ticks the box, and clears the automated checks.
Sadly tho, LeanTween lives in Assets folder not in Package folder. Basically LeanTween is just a custom asset and NOT actual package, which also means we can't make custom if-defines for it
I think that a crucial part of being able to get Fungus back on the asset store is undoing its dependencies on third-party packages like LeanTween. I checked through the source the other day, and found that these scripts (several of which are key to Fungus) depend on LT:
- FadeScreen
- CameraManager
- NarrativeLogMenu
- SaveMenu
- FadeToView
- MoveToView
- TweenUI
- Draggable2D
- Stage
- ControlAudio
- ControlStage
- FadeUI
- TweenUI
The problem here is that fixing these dependencies would mean breaking backwards-compatibility with older Fungus versions pretty hard... Looks like we won't be able to get back on the asset store until we finish version 4.0, since then we'd have an excuse to break BC.
What do you guys think?
In regards to the last item on the list, my read of the policy is that these are the key areas we need address:
- (1.1.e)
Assets with dependencies from Package Manager only include the necessary packages for the asset to work.
- (1.2.c)
You are solely responsible for ensuring that you have all necessary rights to distribute your content on the Asset Store and for end users rightfully to use that content and distribute it as part of a Licensed Product. This means that you are either the owner of all such necessary rights or you have a valid license from the rightsholder.
- (1.2.d)
Your submission includes a Third-Party Notices text file listing fonts, audio, and other third-party components with dependent licenses. You are responsible for ensuring that dependent licenses are compatible with the Asset Store EULA and include a license file detailing the component that it is covering. The product description on the Asset Store also contains a notice stating the third-party software licensing included in the package. For example: "Asset uses [name of component] under [name of license]; see Third-Party Notices.txt file in package for details."
I don't see why we need to remove LeanTween, it seems it should be possible to include it. According to (2.2.a and 2.2.b) the problem is that the LeanTween files being in a compressed file (.unitypackage)
... obscure most of, or the entirety of the content.
Since LeanTween has an open license, we just need to include it in a different way. Which would seem to be as package dependancy to the LeanTween git, or if we just bring the scripts under the Fungus namespace and properly handle the attributions.
Since LT hasn't seen update since 2018, I think we might as well go with the second option so Fungus is complete without a network connection.