snowflake-connector-net icon indicating copy to clipboard operation
snowflake-connector-net copied to clipboard

SNOW-715524: Add SSO token cache

Open sfc-gh-ext-simba-lf opened this issue 1 year ago • 3 comments

Description

Add SSO token cache

Checklist

  • [ ] Code compiles correctly
  • [ ] Code is formatted according to Coding Conventions
  • [ ] Created tests which fail without the change (if possible)
  • [ ] All tests passing (dotnet test)
  • [ ] Extended the README / documentation, if necessary
  • [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name

sfc-gh-ext-simba-lf avatar Apr 18 '24 17:04 sfc-gh-ext-simba-lf

Codecov Report

Attention: Patch coverage is 88.67925% with 30 lines in your changes missing coverage. Please review.

Project coverage is 87.74%. Comparing base (44c7cb3) to head (c2cfa16).

Files with missing lines Patch % Lines
Snowflake.Data/Core/Tools/BrowserOperations.cs 4.54% 21 Missing :warning:
...Core/Authenticator/ExternalBrowserAuthenticator.cs 95.95% 6 Missing and 1 partial :warning:
...ager/Infrastructure/SFCredentialManagerFileImpl.cs 80.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   86.38%   87.74%   +1.36%     
==========================================
  Files         132      133       +1     
  Lines       12679    12814     +135     
  Branches     1302     1318      +16     
==========================================
+ Hits        10953    11244     +291     
+ Misses       1402     1248     -154     
+ Partials      324      322       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 18 '24 18:04 codecov[bot]

Any updates on this PR ? Can I help ? I been waiting for this SSO Token Cache for long time

rafael-sotelo avatar May 16 '24 15:05 rafael-sotelo

Any updates on this PR ? Can I help ? I been waiting for this SSO Token Cache for long time

Currently we're trying out different libraries/packages for the credential manager. Then it'll be reviewed if it meets the security requirements

sfc-gh-ext-simba-lf avatar May 16 '24 17:05 sfc-gh-ext-simba-lf

:tada: Snyk checks have passed. No issues have been found so far.

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)

:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)