SNOW-834781: Remove log4net and delegate logging to consumers
Description
Remove the log4net dependency and replace with the Microsoft logging interface so users can plug in their own custom loggers
Checklist
- [ ] Code compiles correctly
- [ ] Code is formatted according to Coding Conventions
- [ ] Created tests which fail without the change (if possible)
- [ ] All tests passing (
dotnet test) - [ ] Extended the README / documentation, if necessary
- [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name
Codecov Report
:x: Patch coverage is 91.02902% with 34 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 87.37%. Comparing base (9f99d2b) to head (299a07f).
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 87.31% 87.37% +0.06%
==========================================
Files 182 190 +8
Lines 15245 15462 +217
Branches 1567 1601 +34
==========================================
+ Hits 13311 13510 +199
- Misses 1522 1538 +16
- Partials 412 414 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any motion on this PR? I am finding log4net to be impossible to work with in a modern .Net application.
Any motion on this PR? I am finding log4net to be impossible to work with in a modern .Net application.
It's currently undergoing further review
:tada: Snyk checks have passed. No issues have been found so far.
adding NO-CHANGELOG-UPDATES label since this change is already mentioned in the changelog
Merging this since sfc-gh-knozderko requests were addressed and CI passed.