snowflake-connector-net icon indicating copy to clipboard operation
snowflake-connector-net copied to clipboard

SNOW-834781: Remove log4net and delegate logging to consumers

Open sfc-gh-ext-simba-lf opened this issue 1 year ago • 3 comments

Description

Remove the log4net dependency and replace with the Microsoft logging interface so users can plug in their own custom loggers

Checklist

  • [ ] Code compiles correctly
  • [ ] Code is formatted according to Coding Conventions
  • [ ] Created tests which fail without the change (if possible)
  • [ ] All tests passing (dotnet test)
  • [ ] Extended the README / documentation, if necessary
  • [ ] Provide JIRA issue id (if possible) or GitHub issue id in PR name

sfc-gh-ext-simba-lf avatar Nov 09 '24 00:11 sfc-gh-ext-simba-lf

Codecov Report

:x: Patch coverage is 91.02902% with 34 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 87.37%. Comparing base (9f99d2b) to head (299a07f). :white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Snowflake.Data/Core/Tools/ValidatorOperations.cs 60.86% 6 Missing and 3 partials :warning:
Snowflake.Data/Logger/SFConsoleAppender.cs 57.14% 9 Missing :warning:
Snowflake.Data/Logger/SFLoggerPair.cs 86.66% 8 Missing :warning:
Snowflake.Data/Logger/SFRollingFileAppender.cs 92.18% 3 Missing and 2 partials :warning:
...lake.Data/Configuration/EasyLoggingConfigParser.cs 93.75% 0 Missing and 1 partial :warning:
Snowflake.Data/Core/Tools/UnixOperations.cs 95.45% 0 Missing and 1 partial :warning:
Snowflake.Data/Logger/SFLoggerImpl.cs 98.86% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   87.31%   87.37%   +0.06%     
==========================================
  Files         182      190       +8     
  Lines       15245    15462     +217     
  Branches     1567     1601      +34     
==========================================
+ Hits        13311    13510     +199     
- Misses       1522     1538      +16     
- Partials      412      414       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 13 '24 00:11 codecov[bot]

Any motion on this PR? I am finding log4net to be impossible to work with in a modern .Net application.

Coder3333 avatar Jan 24 '25 16:01 Coder3333

Any motion on this PR? I am finding log4net to be impossible to work with in a modern .Net application.

It's currently undergoing further review

sfc-gh-ext-simba-lf avatar Jan 24 '25 18:01 sfc-gh-ext-simba-lf

:tada: Snyk checks have passed. No issues have been found so far.

adding NO-CHANGELOG-UPDATES label since this change is already mentioned in the changelog

sfc-gh-mhofman avatar Oct 01 '25 13:10 sfc-gh-mhofman

Merging this since sfc-gh-knozderko requests were addressed and CI passed.

sfc-gh-mhofman avatar Oct 02 '25 15:10 sfc-gh-mhofman