zelda3
zelda3 copied to clipboard
snesrev
Add toggle for debug keys
Description
Adds a toggle to enable debug keys. The debug keys are now disabled by default, as end users will most likely not want or need them (see many complaints in discord server about saves and progress being overwritten by loading a reference save).
Will this Pull Request break anything?
No, because people who need to use the debug keys can simply re-enable the option through the ini file.
Suggested Testing Steps
Run the game with DebugKeys set to 0, and try doing any debug action. The action should not occur. Then try running the game with DebugKeys set to 1, and observe that the debug keys now work again.
If you were a first time user, you wouldn't know what a "reference save" was or its purpose, so I'm not sure an additional option prevents this problem.
But also, this can already be done by clearing or commenting out the bindings, and that's technically better as you can clear the replay bindings without affecting the cheat ones.
In my experience if people don't know what an option does they keep it disabled. Additionally, commenting out or clearing the debug bindings does not actually work to disable them.