Gauthier Segay
Gauthier Segay
@erlis it makes a lots of sense. The way I see it now, is we could integrate your PR, but we need a bit of effort spent on adding tests...
@cmeeren I think this is related to https://github.com/dotnet/fsharp/issues/10323. I'll see how to make it work out of the box as I'm also facing similar issues, the current work around is...
@cmeeren this is tied to this: https://github.com/fsprojects/FSharp.Data.SqlClient/blob/c8148ebcf6deaf38e87f4e4a34862a104d56bd62/src/SqlClient.DesignTime/SqlClientExtensions.fs#L310 Only value type are option wrapped, which I think makes sense. You may pass `null` to work around your issue.
@cmeeren thanks for the suggestion. `binary` type is currently mapped as `byte array`: https://github.com/fsprojects/FSharp.Data.SqlClient/blob/2ef6c06a2844c2a1b61305bc6b78cbeede090915/src/SqlClient.DesignTime/SqlClientExtensions.fs#L120 How would you like to distinguish when user wants to use byte array or stream or...
@isaacabraham if you have a chance to debug this, the defintion seems to be https://github.com/fsprojects/FSharp.Data.SqlClient/blob/505ecc77471e9607193c4206a71b1abde975face/src/SqlClient/SqlClientExtensions.fs#L269 and we'd need to track down the place the type is actually loaded by the...
@isaacabraham if this is still an issue, would you be able to propose a PR that adds that dependency to the nuget? Are there special considerations needed in context of...
@isaacabraham AFAIR, this kind of behaviour derives from SqlDataAdapater, data adapters tend to be cumbersome in my experience. I think paying a look at https://github.com/fsprojects/FSharp.Data.SqlClient/blob/fb8706f1d96c26c9ca68f3c98df2c5a4a057ba0e/src/SqlClient/DataTable.fs#L59-L86 and considering if we could...
@xkrt if you have a chance, could you check if this issue is still relevant?
@willnationsdev would be relevant places to investigate: https://github.com/fsprojects/FSharp.Data.SqlClient/blob/2ef6c06a2844c2a1b61305bc6b78cbeede090915/src/SqlClient.DesignTime/SqlClientExtensions.fs#L168-L218 https://github.com/fsprojects/FSharp.Data.SqlClient/blob/2ef6c06a2844c2a1b61305bc6b78cbeede090915/src/SqlClient.DesignTime/SqlClientExtensions.fs#L276-L290 https://github.com/fsprojects/FSharp.Data.SqlClient/blob/4450560810f0970894d6a46226dae1ca55d7640d/src/SqlClient.DesignTime/DesignTime.fs#L621-L665 Could you check the kind of results the queries in those areas are returning against your procedure definition?
@charlesroddie thanks for reporting. I've seen this in VS2019, not sure but it could be issue with the TP mishandling the root types, or maybe somehow related to the fact...