smol-ninja

Results 104 comments of smol-ninja

> Is this what you mean ? Yes. > And how do yo want that to be ordered? I'd order the above example as the following: ```solidity import { Strings...

Hi @dbale-altoros, I have just tested the new PR and it looks good. Looking forward to the patch release. Thank you.

Did you mean board or milestone @PaulRBerg? We used board to track v2.2, which I have created one here: https://github.com/orgs/sablier-labs/projects/19/views/2. I am calling it `Lockup 1.2.1` but if it ends...

Unfortunately, there is a problem with this approach. Calls made through `try` statement are external calls to itself, which means it changes the value of `msg.sender` and sets it to...

Thank you to both of you for your comments. > withdrawing to a third-party address would no longer be possible `withdrawMultiple` does not allow withdrawing to third parties so its...

> important assumption — that the Sablier Lockup protocol itself can act as the msg.sender for withdrawals. This can be problematic for hook implementations. This can be problematic for hook...

I have pushed a new commit using `delegatecall`. LMK what you think about it. https://github.com/sablier-labs/v2-core/pull/1101