Results 59 comments of Sam Hauglustaine

@PhilinTv I've added the first 2 tests you mentioned above. It's definitely nice to have those. If I understand right, the 3rd test you suggest would test the effect of...

@PhilinTv this makes sense to me. This deserves a note in the release notes I think: > Remove `defaultValue="0"` from DATETIME|TIMESTAMP column elements in your schema. 0 will now set...

@hsegnitz can you please rebase this PR so tests run? Test errors were fixed recently and that's the easiest way to make them run currently :) This looks good to...

@PhilinTv if you rebase this, only the Pgsql change remains. If still useful, I think it's good to merge? Although maybe wait for the rebase push to run the testsuite?

@PhilinTv if you merge #2052 into this branch, I think this PR is ready to go. It was trying to run those Postgres tests on PHP 7.4 with Symfony 6.x...

@phpfui I would be very interested to see your Propel2 code in https://github.com/phpfui/php-orm-sql-benchmarks. Would you be able to make it available somewhere? Something like `$employee->delete()` works fine as `parent::delete` and...

Thanks! How are you installing Propel? It's not listed in composer.json.

@phpfui sorry, I don't have the capacity to contribute. As related to the original issue: I can't figure out in what scenario the error would occur. While it would make...

@phpfui there doesn't seem to be any code that generates a static closure in Propel2. Specifically, that line in delete() for query classes can be found [here](https://github.com/propelorm/Propel2/blob/6cb272b6d6db09e108f738ae6002bfbf1bda216a/src/Propel/Generator/Builder/Om/QueryBuilder.php#L2011). It wasn't changed...