python-lifx-sdk icon indicating copy to clipboard operation
python-lifx-sdk copied to clipboard

depends on old bitstruct

Open brianmay opened this issue 9 years ago • 3 comments

Hello,

Not sure if we actually need to depend on bitstruct, however I think Python has similar functionality built in and already packaged in Debian.

e.g. https://docs.python.org/2/library/struct.html

In addition bitstruct appears to be buggy and perhaps not really well maintained. https://github.com/eerimoq/bitstruct/issues/5

Regards

brianmay avatar Mar 24 '16 02:03 brianmay

It is well maintained! =)

Hopefully you are satisfied with the new manifest and the explanation of why the testcase failed.

If you want to use the latest version of bitstruct instead of 1.0.0, please note that version 2.0.0 has non-backwards compatible changes. The format specifier b was renamed to r, and ? was renamed to b. r for raw, and b for boolean.

Erik

eerimoq avatar Mar 24 '16 07:03 eerimoq

Just attempting to create a proper Debian package for the latest bitstruct. So I can create a package for lifx-sdk.

bitstruct might be well maintained, not so sure about this project :-(. @smarthall Are you still interested in maintaining this project? If not would you be willing to give me write access to the github respository, the pypi repository, and readthedocs (if applicable) so I can fix some of these problems?

Will keep this bug report as a reminder to check for compatibility. I see I was using bitstruct version 1.0.0, so this might actually be an issue.

brianmay avatar Mar 24 '16 09:03 brianmay

I see some b format specifiers in lifx/protocol.py - I guess these need to be changed to r. I don't see any ? format specifiers.

brianmay avatar Mar 24 '16 09:03 brianmay