sdl_java_suite icon indicating copy to clipboard operation
sdl_java_suite copied to clipboard

Bugfix/issue 1824

Open JulianKast opened this issue 3 years ago • 1 comments

Fixes #1824

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

  • [x] I have verified that I have not introduced new warnings in this PR (or explain why below)
  • [x] I have run the unit tests with this PR
  • [x] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • [x] I have tested Android, Java SE, and Java EE

Unit Tests

Unit test were updated in SystemCapabilityManagerTests.java

Core Tests

Tested to verify that ScreenParams from SystemCapability manager DisplayCapabilities matched DisplayCapabilities from RAIR

Core version / branch / commit hash / module tested against: Manticore v 2.10.0 HMI name / version / branch / commit hash / module tested against: Manticore v 2.10.0

Summary

When we get the new DisplayCapability, we update the old deprecated DisplayCapabilities based on the new DisplayCapability. When we do that, ScreenParams which are a part of DisplayCapabilities don't get set.

This pr checked cached DisplayCapabilities for ScreenParams and updates them to the updated capabilities being set.

Changelog

Bug Fixes
  • Fixes updating DisplayCapabilities

CLA

JulianKast avatar Aug 09 '22 18:08 JulianKast

Codecov Report

Merging #1825 (8251b82) into develop (ccf0af9) will increase coverage by 0.27%. The diff coverage is 25.00%.

:exclamation: Current head 8251b82 differs from pull request most recent head e06a141. Consider uploading reports for the commit e06a141 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1825      +/-   ##
=============================================
+ Coverage      53.78%   54.05%   +0.27%     
- Complexity      5519     5534      +15     
=============================================
  Files            562      562              
  Lines          25809    25828      +19     
  Branches        3395     3400       +5     
=============================================
+ Hits           13881    13961      +80     
+ Misses         10660    10595      -65     
- Partials        1268     1272       +4     
Impacted Files Coverage Δ
...martdevicelink/transport/SdlBroadcastReceiver.java 3.02% <0.00%> (-0.12%) :arrow_down:
...anagers/lifecycle/BaseSystemCapabilityManager.java 67.76% <75.00%> (+0.08%) :arrow_up:
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (ø)
...ink/managers/screen/BaseTextAndGraphicManager.java 64.58% <0.00%> (+0.41%) :arrow_up:
...rc/main/java/com/android/grafika/gles/EglCore.java 44.82% <0.00%> (+2.58%) :arrow_up:
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) :arrow_up:
.../java/com/android/grafika/gles/EglSurfaceBase.java 32.14% <0.00%> (+7.14%) :arrow_up:
...smartdevicelink/encoder/VirtualDisplayEncoder.java 45.69% <0.00%> (+9.60%) :arrow_up:
...main/java/com/android/grafika/gles/Drawable2d.java 67.92% <0.00%> (+11.32%) :arrow_up:
...ava/com/android/grafika/gles/Texture2dProgram.java 59.18% <0.00%> (+24.48%) :arrow_up:
... and 1 more

codecov[bot] avatar Aug 09 '22 20:08 codecov[bot]