certificates icon indicating copy to clipboard operation
certificates copied to clipboard

Add Labels and Annotations to pods

Open daltonstrauss-faro opened this issue 3 years ago • 4 comments

What would you like to be added

Hello! I've created a branch with this change to add extra labels and annotations to pods.

Why this is needed

If I need to set filters using labels or integrations (like Consul) using annotations, I'll need to add then, but now I can't.

daltonstrauss-faro avatar Apr 19 '22 10:04 daltonstrauss-faro

Sorry, it was commented on with another account. This is my account, I have a local branch with this change.

daltonstrauss avatar Apr 19 '22 10:04 daltonstrauss

@daltonstrauss Have you added a PR on the helm-charts repo?

maraino avatar Apr 19 '22 19:04 maraino

@maraino I cannot create branch nor ask for PR. Could you send me the process to do it? Thanks!

daltonstrauss avatar Apr 21 '22 08:04 daltonstrauss

@daltonstrauss you need to fork the helm-chart repo, you can do it by clicking https://github.com/smallstep/helm-charts/fork, which will create a copy in your profile. After that, just clone your own repo, create a branch, and push that branch, GitHub or even git itself will give you the option to create a pull request.

maraino avatar Apr 22 '22 00:04 maraino