certificates icon indicating copy to clipboard operation
certificates copied to clipboard

fix: allow active revocation on http revoke endpoint

Open VonRehberg opened this issue 1 year ago • 1 comments

Name of feature: Allow active revocation via http endpoint

Pain or issue this feature alleviates: active revocation was already possible via cli but not via http

VonRehberg avatar Nov 28 '24 12:11 VonRehberg

Hey @VonRehberg, thank you for the PR.

Can you remove the test at https://github.com/smallstep/certificates/blob/af2e58ab28f3405456aa4276fe5e943ba0f272bc/api/revoke_test.go#L46-L53?

From the looks of it the change looks OK. It seems to stem from the time we only supported passive revocation, but since then support for active revocation was added by the community. In practice the way that is configured and works does seem to make the Passive boolean obsolete, and it seems to be just informational at the moment. I think there's improvements that can be done, but that would require some more work to feed it through, and doesn't need to be in this PR.

hslatman avatar Dec 12 '24 10:12 hslatman

Hi, as this seemed to be stale I continued in https://github.com/smallstep/certificates/pull/2327.

tacerus avatar Jul 06 '25 21:07 tacerus