Shawn Maddock

Also, it’s still in development but there are SDK specific metrics that the SDK should self-report https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/

The way I’m reading https://github.com/open-telemetry/opentelemetry-specification/blob/v1.45.0/specification/resource/sdk.md#specifying-resource-information-via-an-environment-variable is that the Environment detector always has to be last, even after other registry-provided custom detectors, as part of the default detector. I could be...

Ah, I see the circular definition now. I might map that out visually for my own sake, but for the purposes of this PR, this is the part I keep...

Any resource attribute should have mechanisms for users/developers to create overrides. Environment variables or manually setting the attributes as mentioned in https://github.com/open-telemetry/opentelemetry-php/issues/1643#issuecomment-2985050911 should always override them. My thoughts above were...

> I guess the first question is, can this be (or could it be in the future) an auto-instrumentation for more parts of react? i.e., the framework/ecosystem, rather than just...

> Two things are missing that I can see: > > * add to the top-level `.github/workflows/php.yml` so that the tests will be run > * add to the top-level...

Hmm. ~I wonder why `make all` didn’t catch those errors.~ I’ll look into it in a bit. Obviously missed something with code coverage too. Edit: figured out how to use...

> > Absolutely. The other half of the HTTP library is a server, so that’s an obvious choice for what to instrument next. > > Cool, that makes sense. I...

> Hmm. I wonder why `make all` didn’t catch those errors. I’ll look into it in a bit. Obviously missed something with code coverage too. Okay, hopefully I got it...

Okay can we try once more please?