slidev icon indicating copy to clipboard operation
slidev copied to clipboard

Feature(slidev): export pdf with outlines if `--with-toc` option is specified

Open Shinyaigeek opened this issue 3 years ago • 2 comments

Motivation 🔥

Fixes: #662

I implemented a feature to export pdf with outlines. A user can generate a pdf with outlines if they specify --with-toc option in command line.

I happened to see the issue, and it seemed interesting, so I started working on it, but it went better than I expected, so I'm submitting it as a PR. I would like to discuss the implementation policy using this branch as a starting point. Please feel free to comment on any concerns or overlooked points.

Shinyaigeek avatar Jul 31 '22 15:07 Shinyaigeek

I want to say that @lillallol/outline-pdf is not perfect. The outline generated by @lillallol/outline-pdf can only jump to the corresponding page, but in the pdf editor, a good outline can jump to the corresponding part of the corresponding page.

image

condorheroblog avatar Aug 01 '22 10:08 condorheroblog

@condorheroblog Thank you! I feel your concern will be resolved if @tonai’s advice is reflected.

Shinyaigeek avatar Aug 01 '22 16:08 Shinyaigeek

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 19 '22 15:10 stale[bot]

Not stale

Shinyaigeek avatar Oct 20 '22 02:10 Shinyaigeek