SafeEyes icon indicating copy to clipboard operation
SafeEyes copied to clipboard

Escape key doesn't work on wayland

Open UtkarshVerma opened this issue 3 years ago • 7 comments

Describe the bug Pressing escape during a break doesn't exit safeeyes.

To Reproduce Steps to reproduce the behavior:

  1. Take a break
  2. Press escape
  3. Nothing happens

Expected behavior Safeeyes break should be stopped.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Desktop Env: SwayWM / Wayland
  • Version: 2.1.3

UtkarshVerma avatar Jul 03 '22 07:07 UtkarshVerma

Given that we currently have a setting that does not allow breaks to be skipped, do we really want to add escape to skip a break? That would render https://github.com/slgobinath/SafeEyes/pull/603 kind of useless

archisman-panigrahi avatar Aug 04 '24 21:08 archisman-panigrahi

@archisman-panigrahi This is referring to a feature that already exists on X11 - there, pressing Escape on the Break Screen does the same thing as clicking the "Skip" button. It also respects the setting from #603. This issue is just complaining that Wayland is regressing here compared to X11.

deltragon avatar Aug 04 '24 22:08 deltragon

I cannot reproduce with Arch Linux KDE 6.1.3 + Wayland + Safe Eyes 2.2.1. The escape key closes the break screen.

If anyone can reproduce the issue, please reopen.

archisman-panigrahi avatar Aug 04 '24 22:08 archisman-panigrahi

Oh, that's surprising to me - I could have sworn I managed to reproduce this one. I'll check tomorrow.

deltragon avatar Aug 04 '24 23:08 deltragon

I stumbled over this again testing 3.0.0b3, on Plasma 6 Wayland. Reopening.

deltragon avatar May 09 '25 16:05 deltragon

Is the intended feature something like this?

When skip button is shown, escape key plays the same role as the skip button. When skip button is hidden, escape key does not do anything.

archisman-panigrahi avatar May 09 '25 17:05 archisman-panigrahi

Yes, this is the intended feature. This is also how it works on X11 (apart from some bugs).

deltragon avatar May 09 '25 18:05 deltragon