Slava P.

Results 60 comments of Slava P.

@sigmundch this approach with different deployment url for each new version works, but absolutely inconvenient for users.

@sigmundch No, it does not address my concerns :-) First - there is no reference to main.dart.js in index.html at all. Have you looked at the compiled output? There is...

@sigmundch @yjbanov I think "base-href was not intended for versioning" - should remain as it is now, that is not good idea to change it for "versioning". >> I'd suggest...

@yjbanov @sigmundch I did testing by moving everything to sub-folder (named as value taken from .last_build_id), like that: ![image](https://github.com/flutter/flutter/assets/4129763/740248bd-c28c-42f2-b05b-5c025f589759) Obviously, that does not work, because flutter.js has "hardcoded" expectations about...

@JeffOlajos it is not only one main.dart.js file - there are at least 4 files to be changed, see the patch script.

@bojidar-bg It should work without blocking, KEYBOARDON looks as right thing, KEY is ok as well.

@bojidar-bg KEYP/KEY?/KEYDOWNP/KEYDOWN? :key - is quite a good idea as well and consistent with existing mouse support.

@lcuis Yes, it covers my main goal, I can substitute needed params to showDialog() and even call my own dialog functionality. Thank you! Though additional refactoring to allow more control...

@srujzs Looks like the same problem in devtools was "solved" by disabling dart2js optimizations :-( Also trick with safelyPostMessage() extension is not working.

This package needs to be switched from package:js to package:web and package:js_interop