vscode-hack icon indicating copy to clipboard operation
vscode-hack copied to clipboard

Support window/progress message

Open fredemmott opened this issue 7 years ago • 4 comments

FB extension.

Signature here: https://github.com/facebook/hhvm/blob/master/hphp/hack/src/utils/lsp.ml#L850

Efforts to standardize this at https://github.com/Microsoft/language-server-protocol/pull/245 and https://github.com/Microsoft/language-server-protocol/issues/511

fredemmott avatar Jul 09 '18 18:07 fredemmott

What is the best way to get progress messages from the language server? Any current use case?

PranayAgarwal avatar Jul 10 '18 20:07 PranayAgarwal

If they're in clientcapabilities, they should be pushed.

I believe that Hack will push them when initializing if it's not already running; if supported, HHAST could also push them for the whole-repo lint

fredemmott avatar Jul 10 '18 20:07 fredemmott

@fredemmott updated permalink: https://github.com/facebook/hhvm/blob/0c4c1b966bec9cae74d9d35d13ffc93c449fa00a/hphp/hack/src/utils/lsp/lsp.ml#L1007

mroch avatar Jul 30 '19 17:07 mroch

I updated the initialize request to send over the following (in client capabilities):

"workspace": { ... },
"textDocument": { ... },
"window": {
    "status": true,
    "progress": true
}

but still don't get any of those requests from the language server. Anything else I should be doing?

PranayAgarwal avatar Jul 31 '19 18:07 PranayAgarwal