csp-html-webpack-plugin icon indicating copy to clipboard operation
csp-html-webpack-plugin copied to clipboard

Wrong inline script hash when the file EOL is CRLF

Open chihiroxc opened this issue 3 years ago • 1 comments

Description

The hash is wrong when the index.html EOL is CRLF

What type of issue is this? (place an x in one of the [ ])

  • [x] bug
  • [ ] enhancement (feature request)
  • [ ] question
  • [ ] documentation related
  • [ ] testing related
  • [ ] discussion

Requirements (place an x in each of the [ ])

  • [x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I've read and agree to the Code of Conduct.
  • [x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

slackhq/csp-html-webpack-plugin version: 5.1.0

node version: v16.15.1

OS version(s): Windows 10

Steps to reproduce:

  1. Change the index.html EOL to CRLF (the default EOL in Windows)
  2. Generate hash for inline script

Expected result:

The hash is generated correctly.

Actual result:

The hash is wrong for CRLF index.html

chihiroxc avatar Aug 15 '22 03:08 chihiroxc

@chihiroxc I use a forked version of this plugin here and I use Windows and I have no issues. Can you try my forked version: https://github.com/melloware/csp-webpack-plugin

melloware avatar Sep 11 '22 14:09 melloware