react-native-sfsafariviewcontroller icon indicating copy to clipboard operation
react-native-sfsafariviewcontroller copied to clipboard

Upgrade to more recent React Native version

Open blainemuri opened this issue 8 years ago • 1 comments

Current configuration only works on React-Native 0.47.2 or earlier. To have this work on 0.48.x and above, please update the imports of the RCTSFSafariViewController.h file:

Current:

#import <React/RCTBridgeModule.h>
#import <React/RCTConvert.h>
#import <React/RCTEventDispatcher.h>
#import <UIKit/UIKit.h>

Updated:

#import <React/RCTConvert.h>
#import <React/RCTEventDispatcher.h>
#import <UIKit/UIKit.h>


#if __has_include(<React/RCTBridgeModule.h>)
  #import <React/RCTBridgeModule.h>
#else
  #import "RCTBridgeModule.h"
#endif
``

blainemuri avatar Nov 06 '17 23:11 blainemuri

@blainemuri can you provide a pull request? it'll be way better this way, since you already know what to do. Thanks!

skycocker avatar Jul 27 '18 11:07 skycocker