umbraco-doc-type-grid-editor
umbraco-doc-type-grid-editor copied to clipboard
Seeing some crashes on azure app_sevice due to task.result and deadlocking..
trafficstars
Getting errors every now and then with 9.5.2 and dtge 9.0.2, though think it's still in v10.0.1 too.
Think it's this line?? https://github.com/skttl/umbraco-doc-type-grid-editor/blob/dev-v10/src/Our.Umbraco.DocTypeGridEditor/Helpers/DocTypeGridEditorHelper.cs#L252
Subject: We’ve detected that threads are mixing synchronous code with asynchronous code
Review recommendations to avoid deadlocks.
[Microsoft Azure]
We’ve detected that threads are mixing synchronous code with asynchronous code
Azure App Service has identified that 150 threads may be mixing synchronous code with asynchronous code. Application code is calling Task. Result and is synchronously waiting on the Task object, which can lead to deadlocks in the process.
The function calling Task.Result is Our.Umbraco.DocTypeGridEditor.Helpers.DocTypeGridEditorHelper.RenderDocTypeGridEditorItem(Microsoft.AspNetCore.Mvc.IViewComponentHelper, Microsoft.AspNetCore.Mvc.Rendering.IHtmlHelper, Umbraco.Cms.Core.Models.PublishedContent.IPublishedElement, System.String, System.String, System.String, Boolean), but the entire thread's call stack should be reviewed to identify the blocking pattern. Please review the call stack closely and make sure that your code is using the C# await keyword.
HelperMethodFrame_1OBJ
System.Threading.ManualResetEventSlim.Wait
System.Threading.Tasks.Task.SpinThenBlockingWait
System.Threading.Tasks.Task.InternalWaitCore
System.Threading.Tasks.Task1[[System.__Canon System.Private.CoreLib]].GetResultCore System.Threading.Tasks.Task1[[System.__Canon System.Private.CoreLib]].get_Result
Our.Umbraco.DocTypeGridEditor.Helpers.DocTypeGridEditorHelper.RenderDocTypeGridEditorItem
Our.Umbraco.DocTypeGridEditor.Helpers.DocTypeGridEditorHelper.RenderDocTypeGridEditorItem
AspNetCore.app_plugins_doctypegrideditor_render_doctypegrideditor+d__0.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[AspNetCore.app_plugins_doctypegrideditor_render_doctypegrideditor+d__0 czge0biy.5sh]]
AspNetCore.app_plugins_doctypegrideditor_render_doctypegrideditor.ExecuteAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageCoreAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__18.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__18 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderAsync
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__60.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__60 Microsoft.AspNetCore.Mvc.ViewFeatures]]
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.RenderPartialCoreAsync
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__57.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__57 Microsoft.AspNetCore.Mvc.ViewFeatures]]
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.PartialAsync
Microsoft.AspNetCore.Mvc.Rendering.HtmlHelperPartialExtensions.PartialAsync
AspNetCore.Views_Partials_grid_editors_base+d__0.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[AspNetCore.Views_Partials_grid_editors_base+d__0 www.Viewshttp://www.views/]]
AspNetCore.Views_Partials_grid_editors_base.ExecuteAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageCoreAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__18.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__18 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderAsync
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__60.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__60 Microsoft.AspNetCore.Mvc.ViewFeatures]]
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.RenderPartialCoreAsync
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__57.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper+d__57 Microsoft.AspNetCore.Mvc.ViewFeatures]]
Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.PartialAsync
Microsoft.AspNetCore.Mvc.Rendering.HtmlHelperPartialExtensions.PartialAsync
AspNetCore.Views_Partials_grid_TheSiteDoctor+d__1.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[AspNetCore.Views_Partials_grid_TheSiteDoctor+d__1 www.Viewshttp://www.views/]]
AspNetCore.Views_Partials_grid_TheSiteDoctor.renderRow
DynamicClass.CallSite.Target
AspNetCore.Views_Partials_grid_TheSiteDoctor+d__0.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[AspNetCore.Views_Partials_grid_TheSiteDoctor+d__0 www.Viewshttp://www.views/]]
AspNetCore.Views_Partials_grid_TheSiteDoctor.ExecuteAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__20 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageCoreAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19.MoveNext
System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[[Microsoft.AspNetCore.Mvc.Razor.RazorView+d__19 Microsoft.AspNetCore.Mvc.Razor]]
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageAsync
Microsoft.AspNetCore.Mvc.Razor.RazorView+d__18.MoveNext