Greg Venech

Results 62 comments of Greg Venech

@YUzhva great! Feel free to ping me if you need anything clarified or want someone to test the update.

@YUzhva loving how simple this codebase has become. I'm about to try v2 (i.e. `react-leaflet-markercluster@next`) since I just upgraded to `react-leaflet@2`.

@jwmann see my comment above. I modified the equality check in `CircleMarker`.

Disregard, seems possible already using the second `SearchOptions` argument... https://github.com/typesense/typesense-js/blob/master/src/Typesense/Documents.ts#L129-L131

Works with the latest version (v1.2.1) but detecting the `AbortError` through `axios` is a little clunky. May be worth switch to the native `fetch` API at some point where you...

I'm also seeing a number of uninformative warnings with `undefined` that may be related to the cancellation... That may indicate it's not fully supported by the SDK yet? Maybe I...

@sullenor thanks for that clarification, your description makes sense. Can you point me to an example or the source code where that `--config-name` flag is made available? I've never seen...

> Remark is also very good and we can use remark-lint. @sapegin awesome, yeah remark does look like a very good option and I'm already seeing plugins that will let...

Ok so it seems like we're pretty quickly coming to a consensus of using `remark`. Based off what I've read so far, I think that's where my vote would go...

@d3viant0ne yeah sure or we could just close this for now and I'll come back once I've had some time to refactor our markdown processing on webpack.js.org. I already created...