TimeControl icon indicating copy to clipboard operation
TimeControl copied to clipboard

port to ui-lib

Open deltanedas opened this issue 4 years ago • 7 comments

  • port to ui-lib
  • indentation
  • use slider instead of 50 button functions

deltanedas avatar Dec 13 '20 16:12 deltanedas

I made this mod to be as Mobile compatible as possible, as I also originally was a mobile player. So here are the some major drawbacks:

  1. In mobile, one mod or two mod makes a substantial difference. Make the ui-lib optional(and this is why I frown upon libs in general).
  2. Make the slider be fold-able(into a square, while retaining its core functions), like the buttons currently.
  3. Buttons are more pretty, and is bigger, so you don't need to fiddle with 3 or 4 pixels separating x2 and x4 apart.

sk7725 avatar Dec 14 '20 07:12 sk7725

  1. no they dont, ui lib doesnt do much cpu-wise
  2. ?
  3. i agree

deltanedas avatar Dec 14 '20 16:12 deltanedas

no they dont, ui lib doesnt do much cpu-wise

  1. Downloading mods take a long time.
  2. Mobile phones are not guaranteed to have something that can be classified as a decent(or even working cpu), unlike computers.
  3. Some players may not understand what "missing dependancy" is, or not bother at all.

(Below is my rant) ui-lib is good, its just my(and some players') preference to not bother with them(unless you have a lib fetish). It should be optional, if added. I am not against it being added, if it is not a requirement. Also, working with pu and seeing some libs made by others, many times I have felt the "libs" should be distributed in .js/.java form, and not a complete mod. (For one thing, if the latter was true for PU, it would require at least 30 dependancies). Examples are the localized description lib(I forgot the repo) and such. Since you are the main distributor of mindustry mods(I mean holy router that is a lot of libs in your repo list), I really wanted to tell this to you. I have plans to release my libs to the public(yes, under dat gpl), and they will all hopefully be in js form, so that modders will take js/java libs as granted(and easier to use, too).

sk7725 avatar Dec 15 '20 04:12 sk7725

if every mod had its own ui lib then the entire point of being compatible with eachother would be broken instantly

  1. you only have to do it once
  2. doesnt matter, ui lib uses very little cpu and unless you show me a profiler i wont believe otherwise
  3. fuck em, reading is a basic skill

deltanedas avatar Dec 16 '20 15:12 deltanedas

Okay I was drunk, yes, it would break the entire point of ui-lib, I wonder how that slipped my mind...

I'm in some exam stuff rn, exect a push/implementation this weekend!

you only have to do it once

Oh yeah, really lovin this, unlike someone that requires both the lib and mod to be updated cough younggam/multi-lib cough

sk7725 avatar Dec 16 '20 15:12 sk7725

@DeltaNedas didnt you make a mod that auto installs its dependecies?

no they dont, ui lib doesnt do much cpu-wise

  1. Downloading mods take a long time.
  2. Mobile phones are not guaranteed to have something that can be classified as a decent(or even working cpu), unlike computers.
  3. Some players may not understand what "missing dependancy" is, or not bother at all.

(Below is my rant) ui-lib is good, its just my(and some players') preference to not bother with them(unless you have a lib fetish). It should be optional, if added. I am not against it being added, if it is not a requirement. Also, working with pu and seeing some libs made by others, many times I have felt the "libs" should be distributed in .js/.java form, and not a complete mod. (For one thing, if the latter was true for PU, it would require at least 30 dependancies). Examples are the localized description lib(I forgot the repo) and such. Since you are the main distributor of mindustry mods(I mean holy router that is a lot of libs in your repo list), I really wanted to tell this to you. I have plans to release my libs to the public(yes, under dat gpl), and they will all hopefully be in js form, so that modders will take js/java libs as granted(and easier to use, too).

https://github.com/DeltaNedas/yes

USMP-lancer avatar Mar 01 '21 18:03 USMP-lancer

you could just reuse that

USMP-lancer avatar Mar 01 '21 18:03 USMP-lancer