Sivaram
Sivaram
No worries, I will rebase this PR.
build commands: `./autogen.sh && ./configure && make -j13` Execution time (_in seconds_) of [`tests.c`](https://github.com/bitcoin-core/secp256k1/blob/master/src/tests.c) for three iterations (on 64-bit, i7-8750H). I used [`gettime_i64`](https://github.com/bitcoin-core/secp256k1/blob/master/src/bench.h#L15) function to measure the execution time. You...
Makes sense. The change required here is relatively small. I will check other parts of the code for similar issues and bundle them up in a PR.
> Oh I think the `time` command would have been fine-grained enough for the tests. :) I didn't know such a command existed. I initially tried to use `clock_gettime()` for...
I can think of three possible formats for encoding `secp256k1_keypair`: - `seckey || P.x || P.y` - 96 bytes (as mentioned above) - `seckey || P.x` - 64 bytes (assume...
> This implementation does not strictly follow the [BIP340 batch verification spec](https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki#batch-verification). For example, - the random numbers (or randomizers) aren’t generated by passing a seed (hash of all inputs)...
### Questions - Streaming batch API (this PR) vs Single call batch API? - Is transparent verification required? - the current code implements transparent verification (inside `batch_add_*` APIs) - without...
In `extrakeys/bench_impl.h`, cast pointers to `(void *)` before freeing to avoid MSVC warning.
> When running `ccextractor` against a video file, I get an output e.g. like this: > > ```bash > Notice: Teletext page with possible subtitles detected: 152 > - No...
@fjahr, this PR needs review from other contributors regarding the (batch API) design decision made here. The https://github.com/bitcoin-core/secp256k1/pull/1134#pullrequestreview-1083948472 comment showed its support for the "Transparent Verification" feature, which was implemented....