fluid-components icon indicating copy to clipboard operation
fluid-components copied to clipboard

Use GifBuilder for Placeholder images instead of relying on 3rd party

Open sascha-egerer opened this issue 2 years ago • 4 comments

Use GifBuilder to generate a local placeholder image instead of relying on a 3rd party service. This will increase reliability and may also prevent exposure of internal URLs to a third party service.

sascha-egerer avatar Jan 24 '23 22:01 sascha-egerer

I love the idea. Maybe we can provide a solution like: https://github.com/IchHabRecht/filefill/blob/main/Classes/Resource/Handler/ImageBuilderResource.php ?

lukasniestroj avatar Jan 27 '23 15:01 lukasniestroj

We're currently working on another that would provide responsive images (srcset/sizes and picture tag) for fluid components (and especially in the styleguide). In that context we are rethinking placeholder images.

Your PR is valuable input, thank you! However, we might need to move placeholder generation to a separate service class. We will look into it soon.

s2b avatar Jan 27 '23 15:01 s2b

We're currently working on another that would provide responsive images (srcset/sizes and picture tag) for fluid components (and especially in the styleguide). In that context we are rethinking placeholder images.

Your PR is valuable input, thank you! However, we might need to move placeholder generation to a separate service class. We will look into it soon.

Thank you! Sounds good! should I close this PR?

sascha-egerer avatar Jan 27 '23 16:01 sascha-egerer

FYI: This is the current status of development: https://github.com/sitegeist/media-components

s2b avatar Mar 16 '23 15:03 s2b