Jon Surrell

Results 78 comments of Jon Surrell
trafficstars

It seems intentional to me that there is no border in the header. I'd propose updating the preview instead of changing the theme to introduce the border.

It's unclear whether the border is intentional or not. See pNEWy-gud-p2 and p1736784281882349-slack-C087R6MBH36. Either the theme itself or the demo site need to be adjusted.

I don't have access at this time but a fix would look something like this based on the demo site content: 36b0a-pb/#diff

PR to fix the theme: 154545-ghe-Automattic/wpcom-premium-themes

Since WordPress 6.6, WordPress Core supports PHP > 7.2. It likely doesn't make sense to support anything lower than 7.2. Thoughts? https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/

I've created some PRs for this: - 154549-ghe-Automattic/wpcom-premium-themes - 155453-ghe-Automattic/wpcom-a8c-themes - 156544-ghe-Automattic/wpcom-themes - https://github.com/Automattic/themes/pull/8589

Thank you, I've created https://github.com/Automattic/themes/pull/8589 as well.

phpcbf has the issue mentioned here: https://github.com/mattn/efm-langserver/issues/183 There's an issue to revise the exit codes: https://github.com/squizlabs/PHP_CodeSniffer/issues/2898 That results in the formatting output being ignored. I also believe there are some...