phpcs-variable-analysis

phpcs-variable-analysis copied to clipboard

Intended to fix https://github.com/sirbrillig/phpcs-variable-analysis/issues/253

sirbrillig

ETA v3?

23

Hey, Do you have an ETA for when v3 can have a stable tag? arrow functions are not possible if I recall correctly due to constrains in this package Regards,...

Levivb

Inline if-clause with short-list false positive

3

Hello! False-positive: ```php if ( true ) [ $a ] = [ 'hi' ]; // VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable return $a ?? ''; // VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable ``` Fine: ```php if ( true ) {...

sybrew

Improve handling of initial values in initializers

1

I noticed when fixing up the CS, that the `VariableAnalysisSniff::processVariableAsStaticDeclaration()` uses outdated assumptions on what can be part of an initial value: ```php // Are we a static declaration? //...

jrfnl

Add validUndefinedVariableNamesInFileScope

1

Where a variable is available within the File scope, it will not be available within a function scope without the use of `global $varname;`. At the moment it's possible to...

andrewnicols

Feature: Allow variables on a per-file basis

10

I like the idea of allowing some variables only in some files. Other linteres have a `/* global */` special comment, where you can define variables which are passed into...

rvock

As reported in https://github.com/sirbrillig/phpcs-variable-analysis/pull/234 > Array functions like array_merge() and array_values() are "expensive".

sirbrillig

Sniff for detecting single-use variables?

1

Trying to avoid this example BAD (due to refactoring, or simple human error): ```php $has_free_tag = has_tag( 'free' ); if ( $has_free_tag ) { ... } ``` BETTER: ```php if...

lkraav

Unused parameters in methods in abstract classes

3

Abstract classes can contain abstract methods which are _required_ to be overloaded, but they can also contain empty methods which are _optional_ to overload. ```php abstract class Foo { //...

jrfnl

As pointed out by @jrfnl in https://github.com/sirbrillig/phpcs-variable-analysis/pull/207, which added some missing superglobals, `$php_errormsg` is only available conditionally, and even then is deprecated. Therefore I think we should remove it from...

sirbrillig