phpcs-import-detection icon indicating copy to clipboard operation
phpcs-import-detection copied to clipboard

Published 20 hours ago • verified publisher icon sirbrillig

Feature: warn on FQCN usage

Open szepeviktor opened this issue 5 years ago • 4 comments 

    \DrivingTracker\registerDrive($this); // this is fine because it's fully-qualified

Could we have a sniff that is triggered when FQCN is found?

https://github.com/sirbrillig/phpcs-import-detection/blob/572bb1dd8a6b0d15c18abef60695a049e02fac8c/ImportDetection/Sniffs/Imports/RequireImportsSniff.php#L56-L59

szepeviktor avatar Jun 20 '20 19:06 szepeviktor

fully_qualified_strict_types in PHP-CS-Fixer detects only imported ones.

szepeviktor avatar Jun 20 '20 19:06 szepeviktor

So: an additional warning for fully-qualified symbols? Yes, that's certainly do-able. Probably a good idea so that users can have more customization options for this sniff. I'm curious about the use-case?

sirbrillig avatar Jun 24 '20 22:06 sirbrillig

I'm curious about the use-case?

Here it is: someone typed non-imported FQCN-s into our codebase: https://github.com/nunomaduro/larastan/pull/529 and Nuno is looking for a warning + automated fix.

szepeviktor avatar Jun 25 '20 01:06 szepeviktor

Ahh, right. That makes sense. Thanks!

sirbrillig avatar Jun 25 '20 16:06 sirbrillig