singlestoredb-laravel-driver
singlestoredb-laravel-driver copied to clipboard
Fix many things in Connection
Hello @aarondfrancis!
composer require --dev nunomaduro/larastan
vendor/bin/phpstan analyze -c vendor/nunomaduro/larastan/extension.neon -l 5 src/
You will discover things like
diff --git a/src/Connect/Connection.php b/src/Connect/Connection.php
index 5c3e52e..14007af 100644
--- a/src/Connect/Connection.php
+++ b/src/Connect/Connection.php
@@ -6,18 +6,17 @@
namespace SingleStore\Laravel\Connect;
use Illuminate\Database\MySqlConnection;
-use SingleStore\Laravel\Query;
-use SingleStore\Laravel\QueryGrammar;
-use SingleStore\Laravel\Schema;
-use SingleStore\Laravel\SchemaBuilder;
-use SingleStore\Laravel\SchemaGrammar;
+use SingleStore\Laravel\Query\Builder as QueryBuilder;
+use SingleStore\Laravel\Query\Grammar as QueryGrammar;
+use SingleStore\Laravel\Schema\Builder as SchemaBuilder;
+use SingleStore\Laravel\Schema\Grammar as SchemaGrammar;
class Connection extends MySqlConnection
{
/**
* Get a schema builder instance for the connection.
*
- * @return SchemaBuilder
+ * @return \SingleStore\Laravel\Schema\Builder
*/
public function getSchemaBuilder()
{
@@ -25,36 +24,40 @@ class Connection extends MySqlConnection
$this->useDefaultSchemaGrammar();
}
- return new Schema\Builder($this);
+ return new SchemaBuilder($this);
}
/**
* Get the default query grammar instance.
*
- * @return QueryGrammar
+ * @return \Illuminate\Database\Grammar
*/
protected function getDefaultQueryGrammar()
{
- return $this->withTablePrefix(new Query\Grammar);
+ return $this->withTablePrefix(new QueryGrammar);
}
/**
* Get the default schema grammar instance.
*
- * @return SchemaGrammar
+ * @return \Illuminate\Database\Grammar
*/
protected function getDefaultSchemaGrammar()
{
- return $this->withTablePrefix(new Schema\Grammar);
+ return $this->withTablePrefix(new SchemaGrammar);
}
/**
* Get a new query builder instance.
+ *
+ * @return \SingleStore\Laravel\Query\Builder
*/
public function query()
{
- return new Query\Builder(
- $this, $this->getQueryGrammar(), $this->getPostProcessor()
+ return new QueryBuilder(
+ $this,
+ $this->getQueryGrammar(),
+ $this->getPostProcessor()
);
}
}
Do you like static analysis?