query-string
query-string copied to clipboard
feat: implement types schema option parameter
Hi @sindresorhus, I decided to pick up this feature request. I used your comments on this PR: https://github.com/sindresorhus/query-string/pull/249 to help guide me on implementation requirements.
Resolves https://github.com/sindresorhus/query-string/issues/210 related to https://github.com/sindresorhus/query-string/issues/201
Let me know if you have any feedback!
Thanks for working on this
Thanks for the feedback @sindresorhus! I've done a second pass of the doc comments and tried to get it as concise and clear as possible. Let me know if there's any areas you think need reworking 💪
It also needs to be added to the readme. I would wait until the TS docs are done. It should be as close to the TS docs as possible.
Thanks for taking another look at my changes @sindresorhus :muscle:
I've made the corrections, and have added additional context in the TS Docs. Let me know if they look good to you, and I'll get the readme updated accordingly.
I've made the corrections, and have added additional context in the TS Docs. Let me know if they look good to you, and I'll get the readme updated accordingly.
Looks good 👍
That's great @sindresorhus , I've updated the readme.md and have adjusted it slightly to work with the different format of the file. Let me know what you think!
Thanks for contributing 🙏