query-string icon indicating copy to clipboard operation
query-string copied to clipboard

feat: implement types schema option parameter

Open scottenock opened this issue 1 year ago • 2 comments

Hi @sindresorhus, I decided to pick up this feature request. I used your comments on this PR: https://github.com/sindresorhus/query-string/pull/249 to help guide me on implementation requirements.

Resolves https://github.com/sindresorhus/query-string/issues/210 related to https://github.com/sindresorhus/query-string/issues/201

Let me know if you have any feedback!

scottenock avatar May 25 '24 22:05 scottenock

Thanks for working on this

sindresorhus avatar Jun 01 '24 13:06 sindresorhus

Thanks for the feedback @sindresorhus! I've done a second pass of the doc comments and tried to get it as concise and clear as possible. Let me know if there's any areas you think need reworking 💪

scottenock avatar Jun 05 '24 23:06 scottenock

It also needs to be added to the readme. I would wait until the TS docs are done. It should be as close to the TS docs as possible.

sindresorhus avatar Jul 01 '24 22:07 sindresorhus

Thanks for taking another look at my changes @sindresorhus :muscle:

I've made the corrections, and have added additional context in the TS Docs. Let me know if they look good to you, and I'll get the readme updated accordingly.

scottenock avatar Jul 08 '24 14:07 scottenock

I've made the corrections, and have added additional context in the TS Docs. Let me know if they look good to you, and I'll get the readme updated accordingly.

Looks good 👍

sindresorhus avatar Jul 16 '24 22:07 sindresorhus

That's great @sindresorhus , I've updated the readme.md and have adjusted it slightly to work with the different format of the file. Let me know what you think!

scottenock avatar Jul 21 '24 18:07 scottenock

Thanks for contributing 🙏

sindresorhus avatar Jul 22 '24 12:07 sindresorhus