Simonas Pinevičius

Results 28 comments of Simonas Pinevičius
trafficstars

Hi @a4z, could you share your workspace setup? Issue you mentioned uses prebuilt `protoc` which comes from `rules_proto` (downloads binary instead of compiling it). Ordering is important. Maybe something else...

Hi, @timothyg-stripe, so this feature can be enabled only for bazel 7 and up. Could this be done with [skylib versions](https://github.com/bazelbuild/bazel-skylib/blob/main/docs/versions_doc.md)?

Hi, @mateuszkuta256, sorry for delays. I'll try to take a deeper look on weekend.

@lukaszwawrzyk I think doc makes a lot of sense because change is substantial. > Once we are settled on the overall idea, we can try to split these changes into...

Hi, @mateuszkuta256, I think I've introduced more confusion by mentioning build_settings. I thought about it and looks like it's not relevant now. So let's not concentrate on that (I'll share...

Hi, @thirtyseven, have you looked at what @srdo suggested? Maybe that would work? But in general, since jdk does not provide any alternative for exit code trapping is see two...

This was resolved by https://github.com/bazelbuild/rules_scala/pull/1556

Hi @crazyjat, which guide you followed that caused the confusion? I've fixed one instance in https://github.com/bazelbuild/rules_scala/pull/1444 was it this one?

Hi, @haneul, this happens because `descriptor_set_out` (the output of `proto_library`) does not include source info. To change that you have to add `build --protocopt=--include_source_info` to your `.bazelrc` then `scalapb` should...

@gergelyfabian yeah I noticed it doesn't work and that's the reason for reopening. Thought CI passed (probably everything was cached). Trying to solve it.