Ali A Eftekhari

Results 22 comments of Ali A Eftekhari
trafficstars

Hi @SA8416 , Thanks for reporting this issue. One quick solution is to replace `full`, which is deprecated in Julia 1.0, with `Matrix`. Now it should be fixed with the...

Hi @SA8416 , let me investigate it and come back to you. Converting M to a dense matrix is not a memory-efficient fix. I will come back with a better...

I cannot reproduce this error with the master branch of JFVM and julia 1.8 ``` using JFVM #, JFVMvis function diff() Nx = 10 Lx = 1.0 m = createMesh1D(Nx,...

> a more memory-efficient workaround by using the LinearSolve.jl package Very good idea. Let me know if it is faster too. I saw a talk about this package and it...

Hi George, Most probably not. My guess is something can go wrong with the way I handle the cell and face positions. You can give it a try of course....

BTW, I have implemented the 1D spherical in FVTool. You can find an example [here](https://github.com/simulkade/FVTool/blob/master/Examples/Tutorial/diffusiontutorial_spherical.m)

Hi @wangbelle , unfortunately, I never implemented those functions nor do I think I can write them soon. Please feel free to try it yourself; I will help debug as...

Hi @Qiuyan0831 , The negative flash algorithm is described in [a paper](https://www.sciencedirect.com/science/article/pii/037838128980072X) by two of the giants of fluid phase equilibria, Whitson and Michelsen. My implementation is a very basic...

Hi @qingqi-code apologies for the late reply. You are right; i have not incorporated the stability test in the flash calculation function. I've been looking for some time to pay...