docker-simplesamlphp icon indicating copy to clipboard operation
docker-simplesamlphp copied to clipboard

Not explicit enough install instructions

Open llekn opened this issue 5 years ago • 4 comments
trafficstars

Hi,

The README install instructions says:

To get started put the version of simplesamlphp you want to test in a folder named simplesamlphp

I wasted a couple of hours doing echo v1.18.6 > version and a lot of variations on the simplesamlphp folder, until I realized that this meant to put the source code of SimpleSAMLphp on that folder.

Doing a git clone https://github.com/simplesamlphp/docker-simplesamlphp.git and then checking out the desired version did the trick.

I think it would be easier for noobs like me to put this steps explicitly on the README (git clone ..., etc). (or better, to make this docker to checkout a specific version via a environment var)

llekn avatar Apr 29 '20 15:04 llekn

Nice idea! why not create a pull request with all the detailed instructions in the README? I am sure the author will be glad and approve it.

prasannjeet avatar Nov 06 '20 10:11 prasannjeet

Ok, what do you mean by to put the source code of SimpleSAMLphp on that folder. ? :)

nabinkhadka avatar Nov 08 '21 17:11 nabinkhadka

download simplesamlphp source code from official site and extract on that folder

saridzawa avatar Mar 17 '22 09:03 saridzawa

I did the following:

git clone https://github.com/simplesamlphp/docker-simplesamlphp.git
cd ./docker-simplesamlphp
git submodule add https://github.com/simplesamlphp/simplesamlphp.git

From this point you can select the version tag like this:

cd ./simplesamlphp
git checkout v1.19.5

mvaneijken avatar Apr 11 '22 08:04 mvaneijken