request-compose icon indicating copy to clipboard operation
request-compose copied to clipboard

Typo in request/defaults.js

Open gentlefox opened this issue 5 years ago • 1 comments
trafficstars

Line 27:

  'servernam',

Should be:

   'servername',

Side note: love that you've created a HTTP Client solution using FP! Maintaining 20+ servers / microservices that have all been using the old request library, and structurally outdated API format for constructing a request, error handling, and retries - a "One Size Fits Most" legacy. Replacing all this with your module, composing a default to match the old system, while optionally being able to override any other facet. Thank you for making it a coding pleasure.

gentlefox avatar Feb 28 '20 03:02 gentlefox

Good catch! Also thanks for the kind words, I'm glad you like it :+1:

simov avatar Feb 28 '20 07:02 simov