simo

Results 394 comments of simo
trafficstars

I was thinking about possible ways to resolve this, and so here is a little bit of background about why redirecting to the root `/` path by default was chosen....

Thanks for the detailed bug report :+1: Yes, it is an issue with the bundler because Grant loads optional dependencies at runtime where the bundler tries to resolve all `require`...

I did a few improvements on the imports, now all `package.json` imports are wrapped in try catch blocks so they should produce warnings only. On top of that I did...

It's very similar to some of the serverless handlers, and in fact all of them were based on it: ```js var http = require('http') var grant = require('grant').node({ config: {/*configuration...

I think that falls out of scope for this module. Check out [ldapjs.org](http://ldapjs.org), seems like a good client/server implementation for LDAP.

A few things to note here: 1. Grant redirects to `/` by default when it cannot load a provider, see [here](https://github.com/simov/grant/issues/194) 2. DEBUG can log only requests happening on the...

You can put a simple handler before grant: ```js .use('/oauth/:provider/:callback?', (req, res, next) => { console.log(req.session.grant) next() }) ``` This will tell you what's loaded inside the session before entering...

You can try setting up `saveUninitialized` to `true`. Another option to play around is the `resave` one, although that should stay as `false` in most cases.

Thanks for the feedback @vicb, that was really helpful. I don't think we need to update the examples, as they strive to be short and simple, not necessarily with the...

Yes, and since the is your client secret, the best way to do this is by using the [Dynamic State Overrides](https://github.com/simov/grant#dynamic-state). You can play around with it using the [examples](https://github.com/simov/grant/tree/master/examples/dynamic-state)...