db-to-sqlite icon indicating copy to clipboard operation
db-to-sqlite copied to clipboard

Ryancheley patch 1 document updates

Open ryancheley opened this issue 4 years ago • 3 comments
trafficstars

@simonw documentation update to include examples for MS SQL

There may be a better way to show it and explain how it should be done, but I'm at a loss. The connection string for MS SQL with SQL Alchemy are just messy.

I also added headers to the connection string examples to separate them out and make it more clear which example went with which type of SQL.

ryancheley avatar Jul 20 '21 01:07 ryancheley

This looks great!

The place you updated in the README is actually intended as a copy of the output of db-to-sqlite--help

I think this information would work better as a Markdown section in the README itself, similar to the "Using db-to-sqlite with PostgreSQL schemas" section.

simonw avatar Aug 07 '21 17:08 simonw

Doh! 🤦🏻‍♂️

I’ll make an update to move it to its own section 😄

ryancheley avatar Aug 07 '21 20:08 ryancheley

@simonw I made the updates to the documentation to have the MSSQL section separate based on your recommendation to use the "Using db-to-sqlite with PostgreSQL schemas" section.

ryancheley avatar Nov 06 '21 02:11 ryancheley

I should have landed this a year ago! Thanks.

simonw avatar Feb 07 '23 00:02 simonw

Thanks for getting this merged @simonw. Better late than never 😁

ryancheley avatar Feb 11 '23 13:02 ryancheley