stylelint-selector-bem-pattern icon indicating copy to clipboard operation
stylelint-selector-bem-pattern copied to clipboard

Request to move eslint-plugin-jest to devDependency

Open castastrophe opened this issue 1 year ago • 1 comments

I think eslint-plugin-jest should be listed as a devDependency rather than a dependency. I'm installing the utility and it's showing the following warnings:

"stylelint-selector-bem-pattern > [email protected]" has unmet peer dependency "eslint@^7.0.0 || ^8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/[email protected]" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/utils > @eslint-community/[email protected]" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || >=8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/utils > @typescript-eslint/typescript-estree > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

None of these seem required in order to use this stylelint module. Would a PR be accepted with this update?

castastrophe avatar Mar 21 '24 14:03 castastrophe

Hey, yes that makes total sense. Feel free to open a pull request

simonsmith avatar Mar 24 '24 12:03 simonsmith

👋 @simonsmith could you please publish this as a new version? #73 was merged but https://www.npmjs.com/package/stylelint-selector-bem-pattern/v/4.0.0 is still the latest published version.

JoshuaKGoldberg avatar Sep 06 '24 13:09 JoshuaKGoldberg

@JoshuaKGoldberg Done 👌🏻

simonsmith avatar Sep 09 '24 21:09 simonsmith

Awesome thanks!

JoshuaKGoldberg avatar Sep 09 '24 22:09 JoshuaKGoldberg