Simone Busoli

Results 232 comments of Simone Busoli

Hey folks, just a quick note here, after discussing offline with @synapse . In order to figure out how existing tools handle it, we checked out jest and here's what...

created and rebased

tests are broken

> > tests are broken > > I think we need to drop node 14 and 16 for this one it was always part of the original plan, wasn't it?...

> Note that the method names will also need to be added to `lib/internal/test_runner/test.js`: > > https://github.com/nodejs/node/blob/e49cf7acfbfb5ce36f49911d22f533c7056137c2/lib/internal/test_runner/test.js#L103-L120 > > An equivalent change will be required in `test/parallel/test-runner-assert.js`: > > https://github.com/nodejs/node/blob/e49cf7acfbfb5ce36f49911d22f533c7056137c2/test/parallel/test-runner-assert.js#L7-L25...

done and rebased

@ilteoood I'd like to hear your thoughts on this

Good job @puskin94, great to see another member of Nearform's family deserving this nomination 👏

@saisankar428 this is not a reproducible repro I'm afraid, as we can't just run this code and see the issue. Please provide a minimal reproducible repro. See https://stackoverflow.com/help/minimal-reproducible-example