web3dart icon indicating copy to clipboard operation
web3dart copied to clipboard

Published 20 hours ago • verified publisher icon simolus3

wrap all "uninstall filter" calls in try ... catch

Open andromeda911 opened this issue 4 years ago • 3 comments

when websocket connection is closed, "uninstall" method in _FilterEngine throws exception with message from RPC Server "-32000 subscription not found" that stops application and i dont know where we able to catch it.

andromeda911 avatar Jul 02 '21 10:07 andromeda911

I think ignoring the exceptions when unregistering a filter is reasonable. Do you want to open a PR for that?

simolus3 avatar Jul 02 '21 12:07 simolus3

ok, i'll open PR later

andromeda911 avatar Jul 02 '21 12:07 andromeda911

So, where should we catch exceptions after all?

andromeda911 avatar Jul 08 '21 08:07 andromeda911