drift icon indicating copy to clipboard operation
drift copied to clipboard

Fix column writer nullability check

Open westito opened this issue 3 years ago • 3 comments

I found problem (?) with column generation regarding to nullability + converters. The generated data class is not nullable, but other function treat type as nullable. I made a possible fix. Am I right?

Képernyőfotó 2022-05-20 - 14 41 56 Képernyőfotó 2022-05-20 - 14 42 27 Képernyőfotó 2022-05-20 - 14 41 49

westito avatar May 20 '22 13:05 westito

🚀 Deployed on https://deploy-preview-1846--moor.netlify.app

github-actions[bot] avatar May 20 '22 13:05 github-actions[bot]

Huh, looks like this causes us to sometimes generate a duplicate nullability suffix (PureDefault copyWith({MyCustomObject?? txt}) in the failing build step).

simolus3 avatar May 20 '22 18:05 simolus3

I found the problem. Fixed!

westito avatar May 20 '22 20:05 westito