Simon Binder

Results 746 comments of Simon Binder

I'll see if there's a way to use `sqlite_asnyc`'s lock mechanisms within the `QueryDelegate` APIs exposed by drift to avoid implementing `TransactionExecutor` directly.

See https://github.com/davidmartos96/sqlite_async.dart/pull/1 for my approach that uses the `writeTransaction` method from `sqlite_async` with the high-level drift APIs instead of implementing `TransactionExecutor` manually. A downside is that this does not support...

Thanks for offering your help! At the moment, the error is generated by `_LintingVisitor.visitInsertStatement` in `drift_dev/lib/src/analysis/resolver/drift/sqlparser/drift_lints.dart`. That's kind of misplaced, this particular error can be detected and raised by the...

What's your use-case for this? Just a preference / not wanting to throw exceptions to roll back transactions? After all, you could gradually build the transaction inside the callback too....

> but I realized I can't get the last insert rowid after a statement If I'm not missing anything that should be unrelated to transactions? The `execute` interface is the...

> SGTM! Do we need an integration test for this? (Where would we download from though?) I've thought about this as well. A potential integration test could be to: 1....

> Another way to test it would be make a hook that simply fails if some env var is filtered out. The complicated part was passing environment variables without explicitly...

That doesn't help getting entropy. Secure random has been implemented, it's just not on stable yet. So we can just wait.

You're importing `package:sqlite3/sqlite3.dart` somewhere, which does not support being compiled to wasm. You need to use conditional imports to only import `package:sqlite3/wasm.dart` (or `package:sqlite3/common.dart` for platform-agnostic code) when you compile...

I should add that if the maintainers agree that adding e.g. a `connection: RSocketConnectorBuilder.() -> Unit` function to the `HttpClient.rSocket`, I'd be happy to contribute. Just need some guidance on...