Mikael Korpela
Mikael Korpela
Hi! I know this is age-old PR, but I missed reviewing this before! Hope this helps to nudge this forward some day. :-)
I don't remember but I'd imagine something around how we used to show registration/login forms directly in mobile apps and there needing to be a pathway to about page. I...
What would make it easier for you to feel leave a reference? Should there be a way to skip leaving reference, in which case it'd be come public right away?...
I think some guilt and pressure there might be just fine, at the end of the day everyone benefits (notably also collective platform) if people do leave more references? That...
What do you think about placing `modules/i18n/tests/server/convert-translation.bin.tests.js` under `bin/i18n/test/*` so that it's easier to find and connect what it's testing?
`fs-extra` needs to be added in dependencies; looks like it was a transient dependency earlier. We'll need eslint for these. :-) (opened https://github.com/Trustroots/trustroots/pull/1328)
@mrkvon yeah, I think it makes sense. 👍 Let the Gulpfile serve us and not us serve the Gulpfile. 😅 Paths are regular [globs](https://en.wikipedia.org/wiki/Glob_%28programming%29) so your change looks good.
Fabulous! I'll test & review later but meanwhile; you can already use React-i18n `t()` functions to wrap texts so that we can get them to translating once this PR is...
Gotcha! Ping me when good. :-) Oh and on eslint; it also helps to disable eslint per line: ```js console.log(); // eslint-disable-line // eslint-disable-next-line console.log(); ```