silvershop-core icon indicating copy to clipboard operation
silvershop-core copied to clipboard

product variation not viewable/editable by content-authors

Open sparkcom opened this issue 7 years ago • 2 comments
trafficstars

the canEdit / canDelete / canCreate/canView methods need to be defined in the Variation class as content-authors can't work on variation. Currently a way to work around it is to set the permissions using an extension

sparkcom avatar Oct 16 '18 11:10 sparkcom

That is a general SilverStripe "issue" or limitation. DataObjects can never be edited by non-admins if permissions aren't explicitly granted.

Not sure if we should introduce explicit permissions for variations (eg. that editing of variations can be granted to a group of users), or if the permissions should just be inherited from the parent Product? I'm leaning towards the latter approach. Thoughts?

bummzack avatar Oct 16 '18 12:10 bummzack

The latter approach to inherit permissions from parent Product is logical.

There is the same issue with Attribute and AttributeValue. PermissionProvider may be a good solution for them.

sparkcom avatar Oct 19 '18 14:10 sparkcom