libpalaso icon indicating copy to clipboard operation
libpalaso copied to clipboard

Add back ImageToolbox

Open hahn-kev opened this issue 8 months ago • 9 comments

fixes problems in downstream dependents which expected this to be used. This is fixing an issue caused by #1358

Some changes from the original version:

  • no longer supporting Mono/Linux on winforms via OpenFileDialogAdapters, see b9e66261ee98f4d15714810421edd0fd00e9d0a4 for details
  • removed a mono specific test
  • disabled strict mode in the localization manager to fix the broken tests

if you just want to view the changes I made to the code as it was before Joseph removed it you can see this diff: https://github.com/sillsdev/libpalaso/pull/1421/files/baa8e3f335db0b70a96cd3b4154840596d8db430..7e0a2f65c3159c518bad8447da6d40dbfd7ba73c


This change is Reviewable

hahn-kev avatar Apr 01 '25 04:04 hahn-kev

Palaso Tests

     4 files  ± 0       4 suites  ±0   10m 22s :stopwatch: -8s  4 978 tests + 5   4 744 :white_check_mark: +1  234 :zzz: + 4  0 :x: ±0  16 186 runs  +15  15 482 :white_check_mark: +3  704 :zzz: +12  0 :x: ±0 

Results for commit d22a3c92. ± Comparison against base commit 10e9ac3e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 01 '25 04:04 github-actions[bot]

@imnasnainaec done

hahn-kev avatar Apr 08 '25 02:04 hahn-kev

Previously, imnasnainaec (D. Ror.) wrote…

Oh, https://github.com/sillsdev/libpalaso/pull/1358 had no mention in the CHANGELOG of the ImageToolbox removal, so I'm not sure how/whether to mention its restoration. Perhaps just a CHANGELOG entry for what was was changed from the prior ImageToolbox?

If no release version went out since the change (guessing not), then I think we only need to mention what changed. If there was an intervening release version, then the changelog should probably be retroactively modified to show both the removal and re-addition.

tombogle avatar Apr 08 '25 15:04 tombogle

@tombogle this is fixing a change in #1358 how would I check if that went out in a release?

hahn-kev avatar Apr 09 '25 06:04 hahn-kev

You can see the releases here. Unfortunately, instead of giving an exact date, it says version 15.0 was released 3 months ago. I looked at the repo to see the actual date associated with the v15.0.0 tag. Since that was on January 7, the thing you're fixing never went out as a stable release.

tombogle avatar Apr 09 '25 12:04 tombogle

Alright, I've added a changelog entry recording that we removed linux support

hahn-kev avatar Apr 11 '25 03:04 hahn-kev

If there's someone who is actually acquainted with this code or works on a program affected by it, they would probably be best suited to doing the review. Otherwise, I can look at it. I guess I'd just do a diff with the previous versions of these files from early January to see what changed.

tombogle avatar Apr 11 '25 12:04 tombogle

If there's someone who is actually acquainted with this code or works on a program affected by it, they would probably be best suited to doing the review. Otherwise, I can look at it. I guess I'd just do a diff with the previous versions of these files from early January to see what changed.

@tombogle Above, Kevin posted a link with a diff. I used that to approve the changes.

andrew-polk avatar Apr 11 '25 15:04 andrew-polk

You can see the releases here. Unfortunately, instead of giving an exact date, it says version 15.0 was released 3 months ago. I looked at the repo to see the actual date associated with the v15.0.0 tag. Since that was on January 7, the thing you're fixing never went out as a stable release.

Also, you can hover over the "3 months ago" to get the exact datetime. v15.0 says Jan 7th, 18:43 Z

josephmyers avatar Apr 17 '25 06:04 josephmyers